eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

importas: add message if settings contain no aliases (#1956)

Browse Source
This commit is contained in:
Stephen Brown II 2021-05-06 16:58:10 -06:00 committed by GitHub
parent d2526706f8
commit 07a0568df1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pkg/golinters/importas.go
View File

@ -24,6 +24,9 @@ func NewImportAs(settings *config.ImportAsSettings) *goanalysis.Linter {
if settings == nil { if settings == nil {
return return
} }
if len(settings.Alias) == 0 {
lintCtx.Log.Infof("importas settings found, but no aliases listed. List aliases under alias: key.") // nolint: misspell
}
err := analyzer.Flags.Set("no-unaliased", strconv.FormatBool(settings.NoUnaliased)) err := analyzer.Flags.Set("no-unaliased", strconv.FormatBool(settings.NoUnaliased))
if err != nil { if err != nil {

4
test/testdata/configs/importas_noalias.yml vendored Normal file
View File

@ -0,0 +1,4 @@
linters-settings:
importas:
fff: fmt
std_os: os

15
test/testdata/importas_noalias.go vendored Normal file
View File

@ -0,0 +1,15 @@
//args: -Eimportas
//config_path: testdata/configs/importas_noalias.yml
package testdata
import (
wrong_alias "fmt"
"os"
wrong_alias_again "os"
)
func ImportAsNoAlias() {
wrong_alias.Println("foo")
wrong_alias_again.Stdout.WriteString("bar")
os.Stdout.WriteString("test")
}