eeafj/golangci-lint
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

dev: simplify issues and enabled set tests (#3832)

Browse Source
This commit is contained in:
Oleksandr Redko 2023-05-31 23:34:18 +03:00 committed by GitHub
parent afd0ba5278
commit 0520232e01
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
pkg/config/issues_test.go
View File

@ -1,7 +1,6 @@
package config
import (
"fmt"
"testing"
"github.com/stretchr/testify/assert"
@ -10,27 +9,13 @@ import (
func TestGetExcludePatterns(t *testing.T) {
assert.Equal(t, GetExcludePatterns(nil), DefaultExcludePatterns)
include := make([]string, 2)
include[0], include[1] = DefaultExcludePatterns[0].ID, DefaultExcludePatterns[1].ID
include := []string{DefaultExcludePatterns[0].ID, DefaultExcludePatterns[1].ID}
exclude := GetExcludePatterns(include)
assert.Equal(t, len(exclude), len(DefaultExcludePatterns)-len(include))
assert.Len(t, exclude, len(DefaultExcludePatterns)-len(include))
for _, p := range exclude {
// Not in include.
for _, i := range include {
if i == p.ID {
t.Fatalf("%s can't appear inside include.", p.ID)
}
}
// Must in DefaultExcludePatterns.
var inDefaultExc bool
for _, i := range DefaultExcludePatterns {
if i == p {
inDefaultExc = true
break
}
}
assert.True(t, inDefaultExc, fmt.Sprintf("%s must appear inside DefaultExcludePatterns.", p.ID))
assert.NotContains(t, include, p.ID)
assert.Contains(t, DefaultExcludePatterns, p)
}
}

6
pkg/lint/lintersdb/enabled_set_test.go
View File

@ -1,7 +1,6 @@
package lintersdb
import (
"sort"
"testing"
"github.com/stretchr/testify/assert"
@ -109,10 +108,7 @@ func TestGetEnabledLintersSet(t *testing.T) {
enabledLinters = append(enabledLinters, ln)
}
sort.Strings(enabledLinters)
sort.Strings(c.exp)
assert.Equal(t, c.exp, enabledLinters)
assert.ElementsMatch(t, c.exp, enabledLinters)
})
}
}